Skip to content

tools: add eslint rule for hasCrypto checking #13813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 3 commits into from
Closed

tools: add eslint rule for hasCrypto checking #13813

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99699c3
tools: add eslint rule for hasCrypto checking
danbev Jun 20, 2017
b4924a3
test: add eslint-disable crypto-check
danbev Jun 27, 2017
11dc3d0
tools: add eslint rule for inspector checking
danbev Jun 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add eslint-disable crypto-check 
There are currently usages of common.hasCrypto which are not just for
detecting if crypto support is available and then skip the test in
question. For these case we still want to have a lint error generated
which can then be disabled using an ESLint comment.
  • Loading branch information
@danbev
danbev committed Aug 23, 2017
commit b4924a30587865d0adc323aebc1c7955919b054f
2 changes: 1 addition & 1 deletion test/common/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* eslint-disable required-modules */
/* eslint-disable required-modules, crypto-check */
'use strict';
const path = require('path');
const fs = require('fs');
Expand Down
6 changes: 3 additions & 3 deletions test/parallel/test-async-wrap-getasyncid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,14 +81,14 @@ function testInitialized(req, ctor_name) {
}


if (common.hasCrypto) {
if (common.hasCrypto) { // eslint-disable-line crypto-check
const tls = require('tls');
// SecurePair
testInitialized(tls.createSecurePair().ssl, 'Connection');
}


if (common.hasCrypto) {
if (common.hasCrypto) { // eslint-disable-line crypto-check
const crypto = require('crypto');

// The handle for PBKDF2 and RandomBytes isn't returned by the function call,
Expand Down Expand Up @@ -215,7 +215,7 @@ if (common.hasCrypto) {
}


if (common.hasCrypto) {
if (common.hasCrypto) { // eslint-disable-line crypto-check
const TCP = process.binding('tcp_wrap').TCP;
const tcp = new TCP();

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-buffer-alloc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,7 +909,7 @@ assert.throws(() => Buffer.from('', 'buffer'),
}
}

if (common.hasCrypto) {
if (common.hasCrypto) { // eslint-disable-line crypto-check
// Test truncation after decode
const crypto = require('crypto');

Expand Down
1 change: 1 addition & 0 deletions test/parallel/test-buffer-concat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ function assertWrongList(value) {
}));
}

// eslint-disable-next-line crypto-check
const random10 = common.hasCrypto ?
require('crypto').randomBytes(10) :
Buffer.alloc(10, 1);
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-noflag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
require('../common');
const assert = require('assert');

assert.throws(() => require('http2'),
assert.throws(() => require('http2'), // eslint-disable-line crypto-check
/^Error: Cannot find module 'http2'$/);