Skip to content

(v6.x backport) tools: enforce two arguments in assert.throws #13785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 11 commits into from
Closed

(v6.x backport) tools: enforce two arguments in assert.throws #13785

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ffdcfff
test: add msg validation to test-buffer-compare
joshholl Jan 14, 2017
917e579
test: validate error message from buffer.equals
Feb 7, 2017
4056141
test: improve test-buffer-includes.js
toboid Feb 6, 2017
85b17c1
test: validate errors in test-buffer-indexof
edsadr Jan 12, 2017
15b4be8
test: improve the code in test-crypto-dh
edsadr Jan 12, 2017
f40bd47
test: improve test-crypto-rsa-dsa
edsadr Jan 9, 2017
0d27e35
test: extended test to makeCallback cb type check
lucamaraschi Mar 30, 2017
d6b4153
test: improve test-fs-open-flags
vinimdocarmo Jan 20, 2017
593553d
test: add regex in test_cyclic_link_protection
clarenced Feb 19, 2017
7719bc0
test: add second argument to assert.throws
targos Apr 7, 2017
b411cfb
tools: enforce two arguments in assert.throws
targos Apr 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add regex in test_cyclic_link_protection 
PR-URL: #11622
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
@clarenced @targos
clarenced authored and targos committed Jun 19, 2017
commit 593553d3f440294ba7bba95f3852ab6100120534
20 changes: 12 additions & 8 deletions test/parallel/test-fs-realpath.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,21 +190,25 @@ function test_cyclic_link_protection(callback) {
common.skip('symlink test (no privs)');
return runNextTest();
}
const entry = common.tmpDir + '/cycles/realpath-3a';
const entry = path.join(common.tmpDir, '/cycles/realpath-3a');
[
[entry, '../cycles/realpath-3b'],
[common.tmpDir + '/cycles/realpath-3b', '../cycles/realpath-3c'],
[common.tmpDir + '/cycles/realpath-3c', '../cycles/realpath-3a']
[path.join(common.tmpDir, '/cycles/realpath-3b'), '../cycles/realpath-3c'],
[path.join(common.tmpDir, '/cycles/realpath-3c'), '../cycles/realpath-3a']
].forEach(function(t) {
try { fs.unlinkSync(t[0]); } catch (e) {}
fs.symlinkSync(t[1], t[0], 'dir');
unlink.push(t[0]);
});
assert.throws(function() { fs.realpathSync(entry); });
asynctest(fs.realpath, [entry], callback, function(err, result) {
assert.ok(err && true);
return true;
});
assert.throws(() => {
fs.realpathSync(entry);
}, /^Error: ELOOP: too many symbolic links encountered, stat /);
asynctest(
fs.realpath, [entry], callback, common.mustCall(function(err, result) {
assert.strictEqual(err.path, entry);
assert.strictEqual(result, undefined);
return true;
}));
}

function test_cyclic_link_overprotection(callback) {
Expand Down