Skip to content

path: fix posix.relative returns different results #13738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DuanPengfei wants to merge 5 commits into from
Closed

path: fix posix.relative returns different results #13738

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
466faeb
path: fix posix.relative returns different results
DuanPengfei Jun 17, 2017
0864e8e
fix: typo
DuanPengfei Jun 19, 2017
acfdb47
fix: rm unnecessary test
DuanPengfei Jun 19, 2017
8d604e1
feat: `resolve` only throw error when rely on cwd
DuanPengfei Jun 22, 2017
c8bbf22
doc: update `path.posix` and `path.win32` doc
DuanPengfei Jun 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: typo
  • Loading branch information
@DuanPengfei
DuanPengfei committed Jun 22, 2017
commit 0864e8eafe4f5539d225b3623e6b16746274378a
4 changes: 2 additions & 2 deletions lib/path.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,13 @@ function assertPath(path) {

function assertWindowsPlatform(platform) {
// throw an error if direct use the function on *nix platform
if (process.platform !== 'win32')
if (platform !== 'win32')
throw new errors.Error('ERR_UNSUPPORTED_PLATFORM');
}

function assertPosixPlatform(platform) {
// throw an error if direct use the function on windows platform
if (process.process === 'win32')
if (platform === 'win32')
throw new errors.Error('ERR_UNSUPPORTED_PLATFORM');
}

Expand Down