Skip to content

internal/cluster: remove obsolete todo #13734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
refack merged 1 commit into from
Jun 22, 2017
Merged

internal/cluster: remove obsolete todo #13734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
cluster: remove obsolete todo 
PR-URL: #13734
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information
@BridgeAR @refack
BridgeAR authored and refack committed Jun 22, 2017
commit d1871a22c0e7069d03f6b87f829e02ee1c874643
2 changes: 0 additions & 2 deletions lib/internal/cluster/shared_handle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ function SharedHandle(key, address, port, addressType, fd, flags) {
this.handle = null;
this.errno = 0;

// FIXME(bnoordhuis) Polymorphic return type for lack of a better solution.
var rval;

if (addressType === 'udp4' || addressType === 'udp6')
rval = dgram._createSocketHandle(address, port, addressType, fd, flags);
else
Expand Down