Skip to content

test: check zlib version for createDeflateRaw #13697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 6 commits into from
Closed

test: check zlib version for createDeflateRaw #13697

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6db35e8
test: check zlib version for createDeflateRaw
danbev Jun 15, 2017
7e61bcf
add comment about the version check
danbev Jun 15, 2017
a6365bf
use test() instead of match()
danbev Jun 15, 2017
b9833a1
update regex to check for invalid version
danbev Jun 16, 2017
aa525e4
simplify regex
danbev Jun 18, 2017
1441b21
fix spelling of version
danbev Jun 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: check zlib version for createDeflateRaw 
We are currenly builing Node with --shared-zlib which happens to be
version 1.2.8. The test for zlib.createDeflateRaw is expected to fail
but does not when using version 1.2.8.

As far as I can tell the fix referred to in the comments was
introduced in version 1.2.9:
- Reject a window size of 256 bytes if not using the zlib wrapper

This commit suggests adding a check for the version and skipping this
assert if the version is less than 1.2.9.

Refs: http://zlib.net/ChangeLog.txt
  • Loading branch information
@danbev
danbev committed Jun 15, 2017
commit 6db35e80794d1a4401db3cbc23e0c286b3cd20d2
8 changes: 5 additions & 3 deletions test/parallel/test-zlib-failed-init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@ const zlib = require('zlib');
// For raw deflate encoding, requests for 256-byte windows are rejected as
// invalid by zlib.
// (http://zlib.net/manual.html#Advanced)
assert.throws(() => {
zlib.createDeflateRaw({ windowBits: 8 });
}, /^Error: Init error$/);
if (process.versions.zlib.match(/^\d+\.\d+\.[9]|\d{2,}$/)) {
Copy link
Copy Markdown
Member

@benjamingr benjamingr Jun 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to include a link to the reasoning in zlib for this directly rather than having people blame and dig the link from the PR - but I'm fine with other way.

Copy link
Copy Markdown
Contributor Author

@danbev danbev Jun 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, let me add a comment and see what you think. Thanks

Copy link
Copy Markdown
Contributor

@cjihrig cjihrig Jun 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use test() instead of match(). And +1 to adding the comment.

assert.throws(() => {
zlib.createDeflateRaw({ windowBits: 8 });
}, /^Error: Init error$/);
}

// Regression tests for bugs in the validation logic.

Expand Down