Skip to content

test: increase bufsize in child process write test #13626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: increase bufsize in child process write test #13626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: increase bufsize in child process write test 
test-child-process-stdio-big-write-end was failing on ubuntu1604-arm64
because the while loop that was supposed to fill up the buffer ended up
being an infinite loop.

This increases the size of the writes in the loop by 1K until the buffer
fills up.

Fixes: #13603
  • Loading branch information
@Trott
Trott committed Jun 12, 2017
commit 30c1e004f7117c3cd25bed18f47d74ba62ea06ad
11 changes: 6 additions & 5 deletions test/parallel/test-child-process-stdio-big-write-end.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
'use strict';
require('../common');
const assert = require('assert');
const BUFSIZE = 1024;
let bufsize = 0;

switch (process.argv[2]) {
case undefined:
Expand Down Expand Up @@ -51,14 +51,15 @@ function parent() {
// Write until the buffer fills up.
let buf;
do {
buf = Buffer.alloc(BUFSIZE, '.');
sent += BUFSIZE;
bufsize += 1024;
Copy link
Copy Markdown
Contributor

@refack refack Jun 12, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it definitely looks like a /pummel/...
But:

ok 184 parallel/test-child-process-stdio-big-write-end
  ---
  duration_ms: 0.332

🤷‍♂️

buf = Buffer.alloc(bufsize, '.');
sent += bufsize;
} while (child.stdin.write(buf));

// then write a bunch more times.
for (let i = 0; i < 100; i++) {
const buf = Buffer.alloc(BUFSIZE, '.');
sent += BUFSIZE;
const buf = Buffer.alloc(bufsize, '.');
sent += bufsize;
child.stdin.write(buf);
}

Expand Down