Skip to content

Dgram buffers #13623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DamienOReilly wants to merge 13 commits into from
Closed

Dgram buffers #13623

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9d6cd42
doc: added docs for send/receive buffer sizes
DamienOReilly Jun 11, 2017
b84bf95
dgram: support for setting socket buffer size
DamienOReilly Jun 11, 2017
8aed7aa
dgram: tests for setting socket buffer size
DamienOReilly Jun 11, 2017
f7c1aa6
src: udp - support to set socket buffer sizes
DamienOReilly Jun 11, 2017
a99ec11
dgram: fixed indentation
DamienOReilly Jun 11, 2017
2581c09
dgram: added method mapping
DamienOReilly Jun 11, 2017
b0ac4ff
dgram: fixed test for os independence. fixed docs
DamienOReilly Jun 12, 2017
f6bf7f2
dgram: fixed syntax, added options support
DamienOReilly Jun 12, 2017
d5789c0
dgram: add support to get buffer sizes
DamienOReilly Jun 14, 2017
cd79a58
dgram: fixed typos in tests and docs
DamienOReilly Jun 14, 2017
de458d1
dgram: lint errors and other pr comments
DamienOReilly Jun 14, 2017
f196be9
dgram: addressing pr coments
DamienOReilly Jun 21, 2017
f4d3564
dgram: fixed buffer sizes in tests
DamienOReilly Sep 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
dgram: support for setting socket buffer size 
setRecvBufferSize(int) and setSendBufferSize(int)
  • Loading branch information
@DamienOReilly
DamienOReilly committed Sep 10, 2017
commit b84bf9579f87ed17f3fbfdfb42e5232e5634cb11
19 changes: 19 additions & 0 deletions lib/dgram.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,6 +636,25 @@ Socket.prototype.unref = function() {
return this;
};


Socket.prototype.setRecvBufferSize = function(size) {
var err = this._handle.setRecvBufferSize(size);

if (err) {
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig Jun 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style nit: Core prefers no curly braces on single line ifs.

throw errnoException(err, 'setRecvBufferSize');
}
};


Socket.prototype.setSendBufferSize = function(size) {
var err = this._handle.setSendBufferSize(size);
Copy link
Copy Markdown
Member

@jasnell jasnell Jun 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because _handle.setSendBufferSize() includes a CHECK that will abort if size is not UInt32, these should do a proper type check in the js side. Otherwise users will not be happy.

Copy link
Copy Markdown
Contributor

@refack refack Jun 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd prefer a check in JS that will throw an internal/errors.TypeError
this is a good check Number.isFinite(num) && num <= Number.MAX_SAFE_INTEGER && num >= 0;
Ref: https://github.com/nodejs/node/blob/master/lib/internal/process.js#L31
Ref: https://github.com/nodejs/node/blob/master/lib/internal/process.js#L62

Copy link
Copy Markdown
Member

@addaleax addaleax Jun 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good check Number.isFinite(num) && num <= Number.MAX_SAFE_INTEGER && num >= 0;

It’s not an uint32 check, though. I think num >>> 0 === num would work.

Copy link
Copy Markdown
Contributor

@refack refack Jun 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, completely forgot about the existence of >>>
So much fun working with talented people 🕺


if (err) {
throw errnoException(err, 'setSendBufferSize');
}
};


module.exports = {
_createSocketHandle,
createSocket,
Expand Down