Skip to content

url: ensure search property is consistently null vs empty #13606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JustinBeckwith wants to merge 1 commit into from
Closed

url: ensure search property is consistently null vs empty #13606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
url: ensure search property is consistently null vs empty 
Fixes: #13404
  • Loading branch information
@JustinBeckwith
JustinBeckwith committed Jun 11, 2017
commit d7256990877bbda9ed9a71814587bf3793b0188f
4 changes: 2 additions & 2 deletions lib/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {
this.query = this.search.slice(1);
}
} else if (parseQueryString) {
this.search = '';
this.search = null;
this.query = Object.create(null);
}
return this;
Expand Down Expand Up @@ -389,7 +389,7 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {
}
} else if (parseQueryString) {
// no query string, but parseQueryString still requested
this.search = '';
this.search = null;
this.query = Object.create(null);
}

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-url-parse-query.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const parseTestsWithQueryString = {
host: 'example.com',
hostname: 'example.com',
query: createWithNoPrototype(),
search: '',
search: null,
pathname: '/',
path: '/'
},
Expand All @@ -48,7 +48,7 @@ const parseTestsWithQueryString = {
port: null,
hostname: null,
hash: null,
search: '',
search: null,
query: createWithNoPrototype(),
pathname: '/example',
path: '/example',
Expand Down