Skip to content

https: make opts optional & immutable when create #13599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
XadillaX wants to merge 8 commits into from
Closed

https: make opts optional & immutable when create #13599

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
26d4efb
https: make opts optional & immutable when create
XadillaX Jun 10, 2017
2c7ff7b
use Object.assign to instead of util._extend
XadillaX Jun 10, 2017
b3a1ac6
use the default message in common.mustNotCall
XadillaX Jun 10, 2017
9414765
update after reviewing
XadillaX Jun 10, 2017
c798af8
add test case for no argument
XadillaX Jun 10, 2017
5de8cf2
use blocks to instead of server1, server2, ...
XadillaX Jun 10, 2017
dc2291c
add test skip
XadillaX Jun 11, 2017
2232fad
delete default param to prevent some breaking changes
XadillaX Jun 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
delete default param to prevent some breaking changes
  • Loading branch information
@XadillaX
XadillaX committed Jun 13, 2017
commit 2232fad8613477d6e8507b751507b88bc18b3cd9
2 changes: 1 addition & 1 deletion lib/https.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const inherits = util.inherits;
const debug = util.debuglog('https');
const { urlToOptions, searchParamsSymbol } = require('internal/url');

function Server(opts = {}, requestListener) {
function Server(opts, requestListener) {
if (!(this instanceof Server)) return new Server(opts, requestListener);

if (typeof opts === 'function') {
Expand Down