Skip to content

profiler: declare missing printErr #13590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
indutny wants to merge 1 commit into from
Closed

profiler: declare missing printErr #13590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
profiler: declare missing printErr 
`v8/tools/tickprocessor.js` assumes presence of global `printErr`, which
is defined in `d8`.
  • Loading branch information
@indutny
indutny committed Jun 9, 2017
commit 73fa0707a7a328808e0ffff9192d88f5c3049cc5
5 changes: 5 additions & 0 deletions lib/internal/v8_prof_processor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ scriptFiles.forEach(function(s) {
script += process.binding('natives')[s] + '\n';
});

// eslint-disable-next-line no-unused-vars
function printErr(err) {
console.error(err);
}

const tickArguments = [];
if (process.platform === 'darwin') {
tickArguments.push('--mac');
Expand Down