Skip to content

http: fix timeout reset after keep-alive timeout #13549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aqrln wants to merge 3 commits into from
Closed

http: fix timeout reset after keep-alive timeout #13549

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d4d207
http: fix timeout reset after keep-alive timeout
aqrln Jun 8, 2017
e4f645b
fixup! http: fix timeout reset after keep-alive timeout
aqrln Jun 12, 2017
834def6
squash! increase timeouts to fix test flakiness
aqrln Jun 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash! increase timeouts to fix test flakiness
  • Loading branch information
@aqrln
aqrln committed Jun 13, 2017
commit 834def6ceead337be0a3e26437fce6b8cf371bba
4 changes: 2 additions & 2 deletions test/parallel/test-http-server-keep-alive-timeout-slow-client-headers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const server = http.createServer(common.mustCall((req, res) => {
res.end();
}, 2));

server.keepAliveTimeout = 100;
server.keepAliveTimeout = common.platformTimeout(100);

server.listen(0, common.mustCall(() => {
const port = server.address().port;
Expand Down Expand Up @@ -38,7 +38,7 @@ server.listen(0, common.mustCall(() => {
setTimeout(() => {
socket.write('Connection: keep-alive\r\n' +
'\r\n');
}, 200);
}, common.platformTimeout(300));

function onData(chunk) {
response += chunk;
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-http-server-keep-alive-timeout-slow-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ const server = http.createServer(common.mustCall((req, res) => {
}
setTimeout(() => {
res.end('ok');
}, 200);
}, common.platformTimeout(500));
}, 2));

server.keepAliveTimeout = 100;
server.keepAliveTimeout = common.platformTimeout(200);

const agent = new http.Agent({
keepAlive: true,
Expand Down