Skip to content

test: fix flaky test-tls-socket-close #13529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
+16 −5
Closed

test: fix flaky test-tls-socket-close #13529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix flaky test-tls-socket-close 
Add error listener to ignore `ECONNRESET`. Makes test reliable while it
still segfaults (as expected) on Node.js 7.7.3. It might not be possible
to eliminate the probable race causing `ECONNRESET` without also
eliminating the required segfault-inducing part of the test. (Or maybe
it's totally possible. If you figure it out, hey cool, submit a pull
request.)

Fixes: #13184
  • Loading branch information
@Trott
Trott committed Jun 7, 2017
commit 8de9ffd914580afee7ccc6c9b689d8290e680446
21 changes: 16 additions & 5 deletions test/parallel/test-tls-socket-close.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,17 @@ const netServer = net.createServer((socket) => {

netSocket = socket;
}).listen(0, common.mustCall(function() {
// connect client
tls.connect({
connectClient(netServer);
}));

function connectClient(server) {
const tlsConnection = tls.connect({
host: 'localhost',
port: this.address().port,
port: server.address().port,
rejectUnauthorized: false
}).write('foo', 'utf8', common.mustCall(() => {
});

tlsConnection.write('foo', 'utf8', common.mustCall(() => {
assert(netSocket);
netSocket.setTimeout(1, common.mustCall(() => {
assert(tlsSocket);
Expand All @@ -55,4 +60,10 @@ const netServer = net.createServer((socket) => {
}, 1);
}));
}));
}));
tlsConnection.on('error', (e) => {
// Tolerate the occasional ECONNRESET.
// Ref: https://github.com/nodejs/node/issues/13184
if (e.code !== 'ECONNRESET')
throw e;
});
}