Skip to content

tools: remove gyp test directory#1350

Closed
shigeki wants to merge 1 commit into
nodejs:v1.xfrom
shigeki:remove_gyp_test
Closed

tools: remove gyp test directory#1350
shigeki wants to merge 1 commit into
nodejs:v1.xfrom
shigeki:remove_gyp_test

Conversation

@shigeki

@shigeki shigeki commented Apr 6, 2015

Copy link
Copy Markdown
Contributor

gyp tests are not performed in iojs and it's size about 8M bytes. We can check gyp tests outside of iojs and reduce the size of the repository by removing them.
cf. #1325 (comment) ,

tools: remove gyp test directory
13f3fb7 
gyp tests are not performed in iojs and it's size about 8M bytes. We
can check gyp tests outside of iojs and reduce the size of the
repository by removing them.
@jbergstroem

jbergstroem commented Apr 6, 2015

Copy link
Copy Markdown
Member

LGTM

@jbergstroem

jbergstroem commented Apr 6, 2015

Copy link
Copy Markdown
Member

Replying to @Fishrock123's comment in #1325:

I think it was discussed previously that the v8 suite should be untracked..

The v8 directories (and others) are removed when creating tarballs. Since gyp introduced test with this commit I'm more reluctant to have it stay. I guess the unfortunate action was letting it in to the git tree since we now grown the git tree -- I personally don't know a way of removing stuff without rewriting commit history.

@Fishrock123

Fishrock123 commented Apr 6, 2015

Copy link
Copy Markdown
Contributor

I guess the unfortunate action was letting it in to the git tree since we now grown the git tree -- I personally don't know a way of removing stuff without rewriting commit history.

This is something I wish git had an option to disable bits of past history for, even if it technically break things at specific commits without downloading/getting extra repo data.

It gets really bad if you ever deal with already-compressed data in git. (jpegs, tgz, etc)

@jbergstroem jbergstroem mentioned this pull request Apr 6, 2015
Closed
@Fishrock123

Fishrock123 commented Apr 6, 2015

Copy link
Copy Markdown
Contributor

LGTM also

@rvagg

rvagg commented Apr 6, 2015

Copy link
Copy Markdown
Member

lgtm

shigeki pushed a commit to shigeki/node that referenced this pull request Apr 6, 2015
tools: remove gyp test directory
644ece1 
gyp tests are not performed in iojs and it's size about 8M bytes. We
can check gyp tests outside of iojs and reduce the size of the
repository by removing them.

PR-URL: nodejs#1350
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@shigeki

shigeki commented Apr 6, 2015

Copy link
Copy Markdown
Contributor Author

Thanks. Landed in 644ece1 .

@shigeki shigeki closed this Apr 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shigeki @jbergstroem @Fishrock123 @rvagg