Skip to content

async_hooks: rename currentId to currentAsyncId #13490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AndreasMadsen wants to merge 14 commits into from
Closed

async_hooks: rename currentId to currentAsyncId #13490

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d84177e
async_hooks: rename currentId and triggerId
AndreasMadsen Jun 6, 2017
d7fdd11
[squash] fix too long lines
AndreasMadsen Jun 6, 2017
9478347
[squash] correctly deprecate async_hooks.currentId
AndreasMadsen Jun 6, 2017
3328e2c
[squah] refack suggesions
AndreasMadsen Jun 6, 2017
11d0705
[squash] rebase, updated tests
AndreasMadsen Jun 9, 2017
aac29f7
[squash] rename currentAsyncId to executionAsyncId
AndreasMadsen Jun 9, 2017
ed9a42e
[squash] rename triggerId to triggerAsyncId
AndreasMadsen Jun 9, 2017
829f009
[squash] rename C++ API
AndreasMadsen Jun 9, 2017
038b070
[squash] lint
AndreasMadsen Jun 9, 2017
767008f
[squash] rebase fixes
AndreasMadsen Jun 11, 2017
96818e4
[squash] alias C++ renames
AndreasMadsen Jun 12, 2017
248bc1d
[squash] ABI compatiable, use c++14 deprecation syntax
AndreasMadsen Jun 12, 2017
1566af0
[squash] cleanup v8 namespace
AndreasMadsen Jun 13, 2017
86bff35
[squash] no C++14 synatex
AndreasMadsen Jun 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[squash] rebase fixes
  • Loading branch information
@AndreasMadsen
AndreasMadsen committed Jun 13, 2017
commit 767008fac05c65a0d8b5a486e53fd3b86ecade78
4 changes: 2 additions & 2 deletions test/parallel/test-async-wrap-asyncresource-constructor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ assert.throws(() => {

assert.throws(() => {
new AsyncResource('type', -4);
}, /^RangeError: triggerId must be an unsigned integer$/);
}, /^RangeError: triggerAsyncId must be an unsigned integer$/);

assert.throws(() => {
new AsyncResource('type', Math.PI);
}, /^RangeError: triggerId must be an unsigned integer$/);
}, /^RangeError: triggerAsyncId must be an unsigned integer$/);