Skip to content

doc: small makeover for onboarding.md #13413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 9 commits into from
Closed

doc: small makeover for onboarding.md #13413

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4dacb4c
doc: small makeover for onboarding.md
addaleax Jun 2, 2017
c5da1ca
[squash] update based on refack’s review
addaleax Jun 2, 2017
3a99236
[squash] make things less effectively
addaleax Jun 2, 2017
20ee108
[squash] – → ;
addaleax Jun 2, 2017
e771602
[squash] address more of Trott’s nits
addaleax Jun 2, 2017
3f10379
[squash] collaborators → Collaborators
addaleax Jun 2, 2017
8786e75
[squash] new branches: commit → PR
addaleax Jun 7, 2017
16787de
[squash] drop dup’ed sentence
addaleax Jun 7, 2017
b9a776f
[squash] requested changes mentions
addaleax Jun 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[squash] drop dup’ed sentence
  • Loading branch information
@addaleax
addaleax committed Jun 7, 2017
commit 16787de6b0415bd7adc445aece64847fa4b55739
1 change: 0 additions & 1 deletion doc/onboarding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ onboarding session.
* The project has the goals of its contributors

* There are some higher-level goals and values
* Not everything belongs in core (if it can be done reasonably in userland, let it stay in userland)
* Empathy towards users matters (this is in part why we onboard people)
Copy link
Copy Markdown
Contributor

@refack refack Jun 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO empathy is too vague:
Maybe Being kind and courteous towards users is important

Copy link
Copy Markdown
Member

@Trott Trott Jun 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@refack I think "being kind and courteous" is too low a bar. I agree that "empathy" can be hard to define specifically and may not be understood by everyone, but I prefer it to "be nice" which (to me, at least) minimizes things.

Maybe what's needed here is a link on the word "empathy" to another doc (or another part of this doc) that might explain things more fully. Probably out-of-scope for this PR, though. And I'm certainly open to other ideas.

Copy link
Copy Markdown
Member

@Trott Trott Jun 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Also, "be nice to people" is spelled out in the next line, woot!)

Copy link
Copy Markdown
Contributor

@refack refack Jun 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy if we can assume that everyone watched "Star Trek TNG" and knows what an Empath is 😄

* Generally: try to be nice to people!
* The best outcome is for people who come to our issue tracker to feel like they can come back again.
Copy link
Copy Markdown
Member

@Trott Trott Jun 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this line a lot.

Expand Down