Skip to content

lib,tools: fix perm deopts #13384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mscdex merged 4 commits into from
Jun 5, 2017
Merged

lib,tools: fix perm deopts #13384

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8cc8358
tools: fix node args passing in test runner
mscdex Jun 2, 2017
e374e44
events: fix potential permanent deopt
mscdex Jun 2, 2017
fc6f487
process: fix permanent deopt
mscdex Jun 2, 2017
d081548
net: fix permanent deopt
mscdex Jun 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tools: fix node args passing in test runner 
This fixes a regression from 53c88fa so that special arguments
can once again be passed to the node executable when running tests.

PR-URL: #13384
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information
@mscdex
mscdex committed Jun 5, 2017
commit 8cc8358ef74a2ac0d0a662383977c7c80c75ff94
4 changes: 4 additions & 0 deletions tools/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,6 +817,10 @@ def GetConfiguration(self, context):
(file, pathname, description) = imp.find_module('testcfg', [ self.path ])
module = imp.load_module('testcfg', file, pathname, description)
self.config = module.GetConfiguration(context, self.path)
if hasattr(self.config, 'additional_flags'):
self.config.additional_flags += context.node_args
else:
self.config.additional_flags = context.node_args
finally:
if file:
file.close()
Expand Down