Skip to content

Fix timer .unref() handle management once and for all #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
indutny wants to merge 5 commits into from
Closed

Fix timer .unref() handle management once and for all #1330

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
340be32
timers: fix unref() memory leak
trevnorris Nov 26, 2014
31d8801
timers: don't close interval timers when unrefd
Dec 19, 2014
0b39408
timers: do not restart the interval after close
indutny Apr 2, 2015
ca615ac
test: add test for a unref'ed timer leak
indutny Apr 3, 2015
452571b
timers: remove redundant code
indutny Apr 2, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add test for a unref'ed timer leak
  • Loading branch information
@indutny
indutny committed Apr 3, 2015
commit ca615ac4f3d382df6fc10c6dec73523dda324eec
25 changes: 25 additions & 0 deletions test/parallel/test-timers-unref-leak.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
var assert = require('assert');

var called = 0;
var closed = 0;

var timeout = setTimeout(function() {
called++;
}, 10);
timeout.unref();

// Wrap `close` method to check if the handle was closed
var close = timeout._handle.close;
timeout._handle.close = function() {
closed++;
return close.apply(this, arguments);
};

// Just to keep process alive and let previous timer's handle die
setTimeout(function() {
}, 50);

process.on('exit', function() {
assert.equal(called, 1);
assert.equal(closed, 1);
});