Skip to content

deps: add example of comparing OpenSSL changes #13234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 2 commits into from
Closed

deps: add example of comparing OpenSSL changes #13234

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61c16c9
deps: add example of comparing OpenSSL changes
danbev May 26, 2017
7afc371
make the comparison between 1.0.2e and 1.0.2f
danbev May 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
deps: add example of comparing OpenSSL changes 
When upgrading OpenSSL, Step 6 in upgrading guide explains the steps
that need to be taken if asm files need updating. This might not
always be the case and something that needs to be checked from
release to release.

This commit adds an example of using github to manually compare two tags
to see if any changes were made to asm files.
  • Loading branch information
@danbev
danbev committed May 26, 2017
commit 61c16c9c0c5527e1186c69d2192f9f3e58ca6217
7 changes: 7 additions & 0 deletions deps/openssl/doc/UPGRADING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,13 @@ and the other is the older one. sections 6.1 and 6.2 describe the two
types of files. Section 6.3 explains the steps to update the files.
In the case of upgrading 1.0.2f there were no changes to the asm files.

Files changed between two tags can be manually inspected using:
```
https://github.com/openssl/openssl/compare/OpenSSL_1_0_2k...OpenSSL_1_0_2l#files_bucket
Copy link
Copy Markdown
Member

@richardlau richardlau May 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example URL is inconsistent with the rest of this doc; the very first sentence at the beginning of this doc is:

This document describes the procedure to upgrade openssl from 1.0.2e to 1.0.2f in Node.js.

Copy link
Copy Markdown
Contributor Author

@danbev danbev May 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good point, let me fix that. Thanks

```
If any source files in `asm` directory were changed then please follow the rest of the
steps in this section otherwise these steps can be skipped.

### 6.1. asm files for the latest compiler
This was made in `deps/openssl/asm/Makefile`
- Updated asm files for each platforms which are required in
Expand Down