Skip to content

test: refactor event-emitter-check-listener-leaks #13164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: refactor event-emitter-check-listener-leaks #13164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: refactor event-emitter-check-listener-leaks 
* add block-scoping
* use common.mustCall() on callbacks that should not execute
  • Loading branch information
@Trott
Trott committed May 22, 2017
commit d536bb769b4e72b158a354c3a0461ad656832daf
120 changes: 63 additions & 57 deletions test/parallel/test-event-emitter-check-listener-leaks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,73 +25,79 @@ const common = require('../common');
const assert = require('assert');
const events = require('events');

let e = new events.EventEmitter();

// default
for (let i = 0; i < 10; i++) {
e.on('default', common.noop);
}
assert.ok(!e._events['default'].hasOwnProperty('warned'));
e.on('default', common.noop);
assert.ok(e._events['default'].warned);
{
const e = new events.EventEmitter();

// symbol
const symbol = Symbol('symbol');
e.setMaxListeners(1);
e.on(symbol, common.noop);
assert.ok(!e._events[symbol].hasOwnProperty('warned'));
e.on(symbol, common.noop);
assert.ok(e._events[symbol].hasOwnProperty('warned'));
for (let i = 0; i < 10; i++) {
e.on('default', common.mustNotCall());
}
assert.ok(!e._events['default'].hasOwnProperty('warned'));
e.on('default', common.mustNotCall());
assert.ok(e._events['default'].warned);

// specific
e.setMaxListeners(5);
for (let i = 0; i < 5; i++) {
e.on('specific', common.noop);
}
assert.ok(!e._events['specific'].hasOwnProperty('warned'));
e.on('specific', common.noop);
assert.ok(e._events['specific'].warned);
// symbol
const symbol = Symbol('symbol');
e.setMaxListeners(1);
e.on(symbol, common.mustNotCall());
assert.ok(!e._events[symbol].hasOwnProperty('warned'));
e.on(symbol, common.mustNotCall());
assert.ok(e._events[symbol].hasOwnProperty('warned'));

// specific
e.setMaxListeners(5);
for (let i = 0; i < 5; i++) {
e.on('specific', common.mustNotCall());
}
assert.ok(!e._events['specific'].hasOwnProperty('warned'));
e.on('specific', common.mustNotCall());
assert.ok(e._events['specific'].warned);

// only one
e.setMaxListeners(1);
e.on('only one', common.noop);
assert.ok(!e._events['only one'].hasOwnProperty('warned'));
e.on('only one', common.noop);
assert.ok(e._events['only one'].hasOwnProperty('warned'));
// only one
e.setMaxListeners(1);
e.on('only one', common.mustNotCall());
assert.ok(!e._events['only one'].hasOwnProperty('warned'));
e.on('only one', common.mustNotCall());
assert.ok(e._events['only one'].hasOwnProperty('warned'));

// unlimited
e.setMaxListeners(0);
for (let i = 0; i < 1000; i++) {
e.on('unlimited', common.noop);
// unlimited
e.setMaxListeners(0);
for (let i = 0; i < 1000; i++) {
e.on('unlimited', common.mustNotCall());
}
assert.ok(!e._events['unlimited'].hasOwnProperty('warned'));
}
assert.ok(!e._events['unlimited'].hasOwnProperty('warned'));

// process-wide
events.EventEmitter.defaultMaxListeners = 42;
e = new events.EventEmitter();
{
events.EventEmitter.defaultMaxListeners = 42;
const e = new events.EventEmitter();

for (let i = 0; i < 42; ++i) {
e.on('fortytwo', common.noop);
}
assert.ok(!e._events['fortytwo'].hasOwnProperty('warned'));
e.on('fortytwo', common.noop);
assert.ok(e._events['fortytwo'].hasOwnProperty('warned'));
delete e._events['fortytwo'].warned;
for (let i = 0; i < 42; ++i) {
e.on('fortytwo', common.mustNotCall());
}
assert.ok(!e._events['fortytwo'].hasOwnProperty('warned'));
e.on('fortytwo', common.mustNotCall());
assert.ok(e._events['fortytwo'].hasOwnProperty('warned'));
delete e._events['fortytwo'].warned;

events.EventEmitter.defaultMaxListeners = 44;
e.on('fortytwo', common.noop);
assert.ok(!e._events['fortytwo'].hasOwnProperty('warned'));
e.on('fortytwo', common.noop);
assert.ok(e._events['fortytwo'].hasOwnProperty('warned'));
events.EventEmitter.defaultMaxListeners = 44;
e.on('fortytwo', common.mustNotCall());
assert.ok(!e._events['fortytwo'].hasOwnProperty('warned'));
e.on('fortytwo', common.mustNotCall());
assert.ok(e._events['fortytwo'].hasOwnProperty('warned'));
}

// but _maxListeners still has precedence over defaultMaxListeners
events.EventEmitter.defaultMaxListeners = 42;
e = new events.EventEmitter();
e.setMaxListeners(1);
e.on('uno', common.noop);
assert.ok(!e._events['uno'].hasOwnProperty('warned'));
e.on('uno', common.noop);
assert.ok(e._events['uno'].hasOwnProperty('warned'));
{
events.EventEmitter.defaultMaxListeners = 42;
const e = new events.EventEmitter();
e.setMaxListeners(1);
e.on('uno', common.mustNotCall());
assert.ok(!e._events['uno'].hasOwnProperty('warned'));
e.on('uno', common.mustNotCall());
assert.ok(e._events['uno'].hasOwnProperty('warned'));

// chainable
assert.strictEqual(e, e.setMaxListeners(1));
// chainable
assert.strictEqual(e, e.setMaxListeners(1));
}