Skip to content

zlib: option for engine in convenience methods #13089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexanderOMara wants to merge 3 commits into from
Closed

zlib: option for engine in convenience methods #13089

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5ca118
zlib: option for engine in convenience methods
AlexanderOMara May 18, 2017
6773df1
zlib: document convenience methods info option
AlexanderOMara May 22, 2017
3d92331
zlib: adjusted info option description
AlexanderOMara May 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
zlib: document convenience methods info option 
Refs: #8874
  • Loading branch information
@AlexanderOMara
AlexanderOMara committed May 22, 2017
commit 6773df11cbb438217065c173d4fdeb5687c044df
1 change: 1 addition & 0 deletions doc/api/zlib.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,7 @@ ignored by the decompression classes.
* `strategy` {integer} (compression only)
* `dictionary` {Buffer|TypedArray|DataView} (deflate/inflate only, empty dictionary by
default)
* `info` {boolean} (It `true`, returns object with buffer and engine)
Copy link
Copy Markdown
Contributor

@mscdex mscdex May 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/It/If/
s/returns object/returns an object/
Also, perhaps put 'buffer' and 'engine' in backticks to give a hint that they are the actual object property names.

Copy link
Copy Markdown
Contributor Author

@AlexanderOMara AlexanderOMara May 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! Edits made.


See the description of `deflateInit2` and `inflateInit2` at
<http://zlib.net/manual.html#Advanced> for more information on these.
Expand Down