Skip to content

async_wrap,src: promise hook integration #13000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matthewloring wants to merge 16 commits into from
Closed

async_wrap,src: promise hook integration #13000

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ef35de1
async_wrap,src: promise hook integration
Apr 19, 2017
563c1b0
Reintroduce promise hook sharing
May 15, 2017
4aaadc0
Cleanup
May 15, 2017
70f9675
Clean up comments
May 23, 2017
0afbcfc
remove unused variables
addaleax May 21, 2017
833ad39
use .As<>() for casting
addaleax May 21, 2017
5717d75
align arguments (trevnorris review)
addaleax May 21, 2017
34ee31f
add CHECK_NE() (trevnorris review)
addaleax May 21, 2017
e0c194b
re-untangle domain/async_hooks promise support
addaleax May 21, 2017
e1c11e7
async_hooks: only set up hooks if used
addaleax May 21, 2017
d47e97a
Clarify use of additional object to track promise lifespan.
May 23, 2017
012171a
Clarifying comment about destroy hooks in test-promise.js
May 23, 2017
4e38bda
Remove redundant domain tracking
May 23, 2017
13313bb
Fix lint errors
May 24, 2017
9b9c310
Performance improvements
May 24, 2017
81ff7f6
Appease linter
May 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clarifying comment about destroy hooks in test-promise.js
  • Loading branch information
Matt Loring committed May 23, 2017
commit 012171a86db580ae46c6e1e22ebf514e295b4390
1 change: 1 addition & 0 deletions test/async-hooks/test-promise.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,6 @@ function onexit() {
assert.strictEqual(a1.type, 'PROMISE', 'promise request');
assert.strictEqual(typeof a1.uid, 'number', 'uid is a number');
assert.strictEqual(a1.triggerId, 1, 'parent uid 1');
// We expect a destroy hook as well but we cannot guarentee predictable gc.
checkInvocations(a1, { init: 1, before: 1, after: 1 }, 'when process exits');
}