Skip to content

test: make a test path-independent #12945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vsemozhetbyt wants to merge 1 commit into from
Closed

test: make a test path-independent #12945

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: make a test path-independent 
parallel/test-spawn-cmd-named-pipe.js failed with spaces
both in node.exe and test paths.
  • Loading branch information
@vsemozhetbyt
vsemozhetbyt committed May 10, 2017
commit e597b392c2e59db609fb1e43bbaac20c3ada102d
11 changes: 3 additions & 8 deletions test/parallel/test-spawn-cmd-named-pipe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,10 @@ if (!process.argv[2]) {
});
stdoutPipeServer.listen(stdoutPipeName);

const comspec = process.env['comspec'];
if (!comspec || comspec.length === 0) {
assert.fail('Failed to get COMSPEC');
}
const args =
[`"${__filename}"`, 'child', '<', stdinPipeName, '>', stdoutPipeName];

const args = ['/c', process.execPath, __filename, 'child',
'<', stdinPipeName, '>', stdoutPipeName];

const child = spawn(comspec, args);
const child = spawn(`"${process.execPath}"`, args, { shell: true });

child.on('exit', common.mustCall(function(exitCode) {
stdinPipeServer.close();
Expand Down