Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: backport de1461b7efd from upstream v8
Original commit message:

    Drop UniqueId from include/v8.h

    It's unused since March 2 2017 (https://chromium-review.googlesource.com/448539).
    This removes it assuming that leaving it in the header was an oversight.

    BUG=v8:5828

    Review-Url: https://codereview.chromium.org/2732803002
    Cr-Commit-Position: refs/heads/master@{#43605}

Ref: v8/v8@de1461b7efd
  • Loading branch information
addaleax committed May 6, 2017
commit 04eff203fbf54d594a08c15cc7b5784a5f84e2c4
24 changes: 0 additions & 24 deletions deps/v8/include/v8.h
Original file line number Diff line number Diff line change
Expand Up @@ -155,30 +155,6 @@ class GlobalHandles;
} // namespace internal


/**
* General purpose unique identifier.
*/
class UniqueId {
public:
explicit UniqueId(intptr_t data)
: data_(data) {}

bool operator==(const UniqueId& other) const {
return data_ == other.data_;
}

bool operator!=(const UniqueId& other) const {
return data_ != other.data_;
}

bool operator<(const UniqueId& other) const {
return data_ < other.data_;
}

private:
intptr_t data_;
};

// --- Handles ---

#define TYPE_CHECK(T, S) \
Expand Down
1 change: 0 additions & 1 deletion deps/v8/test/cctest/test-api-interceptors.cc
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ using ::v8::String;
using ::v8::Symbol;
using ::v8::TryCatch;
using ::v8::Undefined;
using ::v8::UniqueId;
using ::v8::V8;
using ::v8::Value;

Expand Down
1 change: 0 additions & 1 deletion deps/v8/test/cctest/test-api.cc
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ using ::v8::String;
using ::v8::Symbol;
using ::v8::TryCatch;
using ::v8::Undefined;
using ::v8::UniqueId;
using ::v8::V8;
using ::v8::Value;

Expand Down
1 change: 0 additions & 1 deletion deps/v8/test/cctest/test-global-handles.cc
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
#include "test/cctest/cctest.h"

using namespace v8::internal;
using v8::UniqueId;

TEST(EternalHandles) {
CcTest::InitializeVM();
Expand Down