Skip to content

Revert "net: remove unnecessary process.nextTick()" #12854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evanlucas merged 2 commits into from
May 23, 2017
Merged

Revert "net: remove unnecessary process.nextTick()" #12854

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba0dbaa
Revert "net: remove unnecessary process.nextTick()"
evanlucas May 5, 2017
2cf4882
test: add regression test for immediate socket errors
evanlucas May 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: add regression test for immediate socket errors 
This test ensures that a http client request with the default agent
that has a socket that is immediately destroyed can still be caught by
adding an error event listener to the request object.

PR-URL: #12854
Fixes: #12841
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
@evanlucas
evanlucas committed May 23, 2017
commit 2cf4882136b2c17c37aeb7b793a3040e64936b9f
12 changes: 12 additions & 0 deletions test/parallel/test-http-client-immediate-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
'use strict';

// Make sure http.request() can catch immediate errors in
// net.createConnection().

const common = require('../common');
const assert = require('assert');
const http = require('http');
const req = http.get({ host: '127.0.0.1', port: 1 });
req.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ECONNREFUSED');
}));