Skip to content

src: do proper StringBytes error handling #12765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
Closed

src: do proper StringBytes error handling #12765

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0aff46e
src: do proper StringBytes error handling
addaleax Apr 30, 2017
2ea112b
[squash] throw errors for crypto return
addaleax Apr 30, 2017
a65a5c3
[squash] remove goto → inline error statements
addaleax Apr 30, 2017
389af5a
[squash] remove indentation for the fast case
addaleax May 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[squash] throw errors for crypto return
  • Loading branch information
@addaleax
addaleax committed May 1, 2017
commit 2ea112b8919d371f7d874e4382cecc436b37705b
16 changes: 10 additions & 6 deletions src/node_crypto.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3816,9 +3816,11 @@ void Hmac::HmacDigest(const FunctionCallbackInfo<Value>& args) {
encoding,
&error);
delete[] md_value;
// TODO(addaleax): Throw `error` here. This isn't so terribly important,
// hashes are very short so creating the corresponding strings is very
// unlikely to fail.
if (rc.IsEmpty()) {
CHECK(!error.IsEmpty());
env->isolate()->ThrowException(error);
return;
}
args.GetReturnValue().Set(rc.ToLocalChecked());
}

Expand Down Expand Up @@ -3942,9 +3944,11 @@ void Hash::HashDigest(const FunctionCallbackInfo<Value>& args) {
md_len,
encoding,
&error);
// TODO(addaleax): Throw `error` here. This isn't so terribly important,
// hashes are very short so creating the corresponding strings is very
// unlikely to fail.
if (rc.IsEmpty()) {
CHECK(!error.IsEmpty());
env->isolate()->ThrowException(error);
return;
}
args.GetReturnValue().Set(rc.ToLocalChecked());
}

Expand Down