Skip to content

src: turn buffer type-CHECK into exception #12753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

src: turn buffer type-CHECK into exception #12753

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ef674f
src: turn buffer type-CHECK into exception
addaleax Apr 29, 2017
a9e1bba
[squash] fixup test
addaleax May 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: turn buffer type-CHECK into exception 
Turn a `CHECK()` that could be brought to fail using public APIs
into throwing an error.

Fixes: #12152
  • Loading branch information
@addaleax
addaleax committed May 3, 2017
commit 6ef674f22cfac6556db0d6e4b5d0268eba71d14f
7 changes: 6 additions & 1 deletion src/stream_base.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,9 +189,14 @@ int StreamBase::Writev(const FunctionCallbackInfo<Value>& args) {

int StreamBase::WriteBuffer(const FunctionCallbackInfo<Value>& args) {
CHECK(args[0]->IsObject());
CHECK(Buffer::HasInstance(args[1]));

Environment* env = Environment::GetCurrent(args);

if (!args[1]->IsUint8Array()) {
env->ThrowTypeError("Second argument must be a buffer");
return 0;
}

Local<Object> req_wrap_obj = args[0].As<Object>();
const char* data = Buffer::Data(args[1]);
size_t length = Buffer::Length(args[1]);
Expand Down
7 changes: 7 additions & 0 deletions test/parallel/test-stream-base-typechecking.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
'use strict';
require('../common');
const assert = require('assert');

assert.throws(() => {
process.stdout.write('broken', 'buffer');
}, /^TypeError: Second argument must be a buffer$/);