Skip to content

test: refactoring test with common.mustCall #12702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
weewey wants to merge 3 commits into from
Closed

test: refactoring test with common.mustCall #12702

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ca46bb
test: refactoring test with common.mustCall
weewey Apr 28, 2017
78753ee
improved formatting, added common.mustCall and refactor this.address(…
weewey Apr 29, 2017
047045c
adding back assert.strictEqual to track both requests are completed b…
weewey May 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
adding back assert.strictEqual to track both requests are completed b… 
…efore server is closed. Adding common.mustCall to checkCertReq.
  • Loading branch information
@weewey
weewey committed May 2, 2017
commit 047045ceee683456a2ad2ae5865d14ca4bb54fb2
21 changes: 18 additions & 3 deletions test/parallel/test-https-simple.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,16 @@ const options = {
cert: fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem')
};

const tests = 2;
let successful = 0;

const testSucceeded = function() {
successful = successful + 1;
if (successful === tests) {
server.close();
}
};

const body = 'hello world\n';

const serverCallback = common.mustCall(function(req, res) {
Expand Down Expand Up @@ -67,6 +77,7 @@ server.listen(0, common.mustCall(() => {

res.on('end', common.mustCall(() => {
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig Apr 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enclosing https.request() and server.listen() callbacks need to have common.mustCall() too, or there is no guarantee that this will execute.

assert.strictEqual(responseBody, body);
testSucceeded();
}));
}));
req.end();
Expand Down Expand Up @@ -94,8 +105,12 @@ server.listen(0, common.mustCall(() => {
});
checkCertReq.end();

checkCertReq.on('error', function(e) {
checkCertReq.on('error', common.mustCall((e) => {
assert.strictEqual(e.code, 'UNABLE_TO_VERIFY_LEAF_SIGNATURE');
server.close();
});
testSucceeded();
}));
}));

process.on('exit', function() {
assert.strictEqual(successful, tests);
});