Skip to content

test: remove AIX guard in fs-options-immutable #12687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thefourtheye wants to merge 1 commit into from
Closed

test: remove AIX guard in fs-options-immutable #12687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: remove AIX guard in fs-options-immutable 
The fs watch test was not run on AIX till now because of the known
issue, #5085. Now that it is
completed, this guard can be removed.
  • Loading branch information
@thefourtheye
thefourtheye committed Apr 27, 2017
commit aafd3904f99654056cc1b9e7a1414f2e783fa862
24 changes: 10 additions & 14 deletions test/parallel/test-fs-options-immutable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,21 +58,17 @@ if (common.canCreateSymLink()) {
);
}

if (!common.isAix) {
// TODO(thefourtheye) Remove this guard once
// https://github.com/nodejs/node/issues/5085 is fixed
{
let watch;
assert.doesNotThrow(() => {
watch = fs.watch(__filename, options, common.noop);
});
watch.close();
}
{
let watch;
assert.doesNotThrow(() => {
watch = fs.watch(__filename, options, common.noop);
});
watch.close();
}

{
assert.doesNotThrow(() => fs.watchFile(__filename, options, common.noop));
fs.unwatchFile(__filename);
}
{
assert.doesNotThrow(() => fs.watchFile(__filename, options, common.noop));
fs.unwatchFile(__filename);
}

{
Expand Down