Skip to content

lib: refactor some internal/* code #12644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 5 commits into from
Closed

lib: refactor some internal/* code #12644

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7008983
process: refactor internal/process.js export style
jasnell Apr 24, 2017
dc289b3
module: refactor internal/module export style
jasnell Apr 24, 2017
3d75f9f
streams: refactor BufferList into ES6 class
jasnell Apr 24, 2017
ae8de10
fs: simplify constant decls
jasnell Apr 25, 2017
0c9bd21
freelist: simplify export
jasnell Apr 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
freelist: simplify export
  • Loading branch information
@jasnell
jasnell committed Apr 27, 2017
commit 0c9bd21b072cd610c2ed71f0b015a747139e0d8d
2 changes: 1 addition & 1 deletion lib/_http_common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const binding = process.binding('http_parser');
const methods = binding.methods;
const HTTPParser = binding.HTTPParser;

const FreeList = require('internal/freelist').FreeList;
const FreeList = require('internal/freelist');
const ondrain = require('internal/http').ondrain;
const incoming = require('_http_incoming');
const IncomingMessage = incoming.IncomingMessage;
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/freelist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ class FreeList {
}
}

module.exports = {FreeList};
module.exports = FreeList;
7 changes: 3 additions & 4 deletions test/parallel/test-freelist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,11 @@

require('../common');
const assert = require('assert');
const freelist = require('internal/freelist');
const FreeList = require('internal/freelist');

assert.strictEqual(typeof freelist, 'object');
assert.strictEqual(typeof freelist.FreeList, 'function');
assert.strictEqual(typeof FreeList, 'function');

const flist1 = new freelist.FreeList('flist1', 3, String);
const flist1 = new FreeList('flist1', 3, String);

// Allocating when empty, should not change the list size
const result = flist1.alloc('test');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-internal-modules-expose.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ const config = process.binding('config');

console.log(config, process.argv);

assert.strictEqual(typeof require('internal/freelist').FreeList, 'function');
assert.strictEqual(typeof require('internal/freelist'), 'function');
assert.strictEqual(config.exposeInternals, true);