Skip to content

build: use do_not_edit variable in configure script #12610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krydos wants to merge 1 commit into from
Closed

build: use do_not_edit variable in configure script #12610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: use do_not_edit variable where possible 
We should not use hardcoded string to warn users about
file was generated by configure script. Since we already
have do_not_edit variable we can use it
  • Loading branch information
@krydos
krydos committed Apr 23, 2017
commit 040b1c2894ca9de3255daa55875e811c61863c03
3 changes: 1 addition & 2 deletions configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1370,8 +1370,7 @@ if options.prefix:

config = '\n'.join(map('='.join, config.iteritems())) + '\n'

write('config.mk',
'# Do not edit. Generated by the configure script.\n' + config)
write('config.mk', do_not_edit + config)

gyp_args = [sys.executable, 'tools/gyp_node.py', '--no-parallel']

Expand Down