Skip to content

test: add coverage for napi_cancel_async_work #12575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 3 commits into from
Closed

test: add coverage for napi_cancel_async_work #12575

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a73a991
test: add coverage for napi_cancel_async_work
mhdawson Apr 21, 2017
2a1d442
squash: address first set of comments
mhdawson Apr 24, 2017
2457375
squash: shorten test time
mhdawson Apr 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: address first set of comments
  • Loading branch information
@mhdawson
mhdawson committed Apr 24, 2017
commit 2a1d442c54899a8bbf82ed8b17d7ced4caafe9a5
4 changes: 2 additions & 2 deletions test/addons-napi/test_async/test_async.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ void Complete(napi_env env, napi_status status, void* data) {

napi_value result;
NAPI_CALL_RETURN_VOID(env,
napi_call_function(env, global, callback, 2, argv, &result));
napi_make_callback(env, global, callback, 2, argv, &result));

NAPI_CALL_RETURN_VOID(env, napi_delete_reference(env, c->_callback));
NAPI_CALL_RETURN_VOID(env, napi_delete_async_work(env, c->_request));
Expand Down Expand Up @@ -135,7 +135,7 @@ void CancelComplete(napi_env env, napi_status status, void* data) {
NAPI_CALL_RETURN_VOID(env, napi_get_global(env, &global));
napi_value result;
NAPI_CALL_RETURN_VOID(env,
napi_call_function(env, global, callback, 0, nullptr, &result));
napi_make_callback(env, global, callback, 0, nullptr, &result));
}

NAPI_CALL_RETURN_VOID(env, napi_delete_async_work(env, c->_request));
Expand Down