Skip to content

test: remove flaky designation for test on AIX #12564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: remove flaky designation for test on AIX #12564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: remove flaky designation for test on AIX 
#5085 has been completed so
presumably test-fs-watch is not flaky on AIX anymore. Remove flaky
designation from sequential.status.
  • Loading branch information
@Trott
Trott committed Apr 21, 2017
commit 8469a3c3d57775dd087fa55148abb046113ff516
5 changes: 0 additions & 5 deletions test/sequential/sequential.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,4 @@ test-benchmark-child-process : PASS,FLAKY

[$system==freebsd]

# fs-watch currently needs special configuration on AIX and we
# want to improve under https://github.com/nodejs/node/issues/5085.
# Tests are disabled so CI can be green and we can spot other
# regressions until this work is complete
[$system==aix]
test-fs-watch : FAIL,PASS
5 changes: 3 additions & 2 deletions test/sequential/test-fs-watch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ const fs = require('fs');

const expectFilePath = common.isWindows ||
common.isLinux ||
common.isOSX;
common.isOSX ||
common.isAix;

let watchSeenOne = 0;
let watchSeenTwo = 0;
Expand Down Expand Up @@ -101,7 +102,7 @@ const filepathThree = path.join(testsubdir, filenameThree);
assert.doesNotThrow(
function() {
const watcher = fs.watch(testsubdir, function(event, filename) {
const renameEv = common.isSunOS ? 'change' : 'rename';
const renameEv = common.isSunOS || common.isAix ? 'change' : 'rename';
assert.strictEqual(renameEv, event);
if (expectFilePath) {
assert.strictEqual('newfile.txt', filename);
Expand Down