Skip to content

test: dynamic port in test cluster eaddrinuse #12547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sebastianplesciuc wants to merge 1 commit into from
Closed

test: dynamic port in test cluster eaddrinuse #12547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: dynamic port in cluster eaddrinuse 
Removed common.PORT from test-cluster-eaddrinuse to eliminate the
possibility that a dynamic port used in another test will collide
with common.PORT.

Refs: #12376
  • Loading branch information
Sebastian Plesciuc committed Apr 20, 2017
commit a60395118cc23ce31ff9c651975e06e7a67fbc1a
9 changes: 5 additions & 4 deletions test/parallel/test-cluster-eaddrinuse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,12 @@ const fork = require('child_process').fork;
const net = require('net');

const id = '' + process.argv[2];
const port = '' + process.argv[3];

if (id === 'undefined') {
const server = net.createServer(common.mustNotCall());
server.listen(common.PORT, function() {
const worker = fork(__filename, ['worker']);
server.listen(0, function() {
const worker = fork(__filename, ['worker', server.address().port]);
worker.on('message', function(msg) {
if (msg !== 'stop-listening') return;
server.close(function() {
Expand All @@ -44,14 +45,14 @@ if (id === 'undefined') {
});
} else if (id === 'worker') {
let server = net.createServer(common.mustNotCall());
server.listen(common.PORT, common.mustNotCall());
server.listen(port, common.mustNotCall());
server.on('error', common.mustCall(function(e) {
assert(e.code, 'EADDRINUSE');
process.send('stop-listening');
process.once('message', function(msg) {
if (msg !== 'stopped-listening') return;
server = net.createServer(common.mustNotCall());
server.listen(common.PORT, common.mustCall(function() {
server.listen(port, common.mustCall(function() {
server.close();
}));
});
Expand Down