Skip to content

(v6.x backport) Doc and test cert apis #12468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sam-github wants to merge 6 commits into from
Closed

(v6.x backport) Doc and test cert apis #12468

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cc1d02d
test: getgroups() may contain duplicate GIDs
sam-github Dec 21, 2016
05039c3
doc,test: tls .ca option supports multi-PEM files
sam-github Dec 21, 2016
d59c9f5
test: tls cert chain completion scenarios
sam-github Dec 20, 2016
7c6aec6
doc: use correct tls certificate property name
sam-github Dec 20, 2016
fd97d25
test: check tls server verification with addCACert
sam-github Dec 20, 2016
8db0443
test: move common tls connect setup into fixtures
sam-github Dec 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: getgroups() may contain duplicate GIDs 
Some systems may have multiple group names with the same group ID, in
which case getgroups() returns duplicate values, where `id -G` will
filter the duplicates. Unique and sort the arrays so they can be
compared.

PR-URL: #10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
  • Loading branch information
@sam-github
sam-github committed Apr 17, 2017
commit cc1d02d2f7ce4f295bfe3b835d161a363f09d9db
18 changes: 12 additions & 6 deletions test/parallel/test-process-getgroups.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,23 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const exec = require('child_process').exec;

// Check `id -G` and `process.getgroups()` return same groups.

if (common.isOSX) {
common.skip('Output of `id -G` is unreliable on Darwin.');
return;
}
const assert = require('assert');
const exec = require('child_process').exec;

if (typeof process.getgroups === 'function') {
const groups = process.getgroups();
const groups = unique(process.getgroups());
assert(Array.isArray(groups));
assert(groups.length > 0);
exec('id -G', function(err, stdout) {
if (err) throw err;
const real_groups = stdout.match(/\d+/g).map(Number);
assert.strictEqual(groups.length, real_groups.length);
assert.ifError(err);
const real_groups = unique(stdout.match(/\d+/g).map(Number));
assert.deepStrictEqual(groups, real_groups);
check(groups, real_groups);
check(real_groups, groups);
});
Expand All @@ -24,3 +26,7 @@ if (typeof process.getgroups === 'function') {
function check(a, b) {
for (let i = 0; i < a.length; ++i) assert.notStrictEqual(b.indexOf(a[i]), -1);
}

function unique(groups) {
return [...new Set(groups)].sort();
}