Skip to content

console: make console consistent with the standard - overridable #12454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Wandalen wants to merge 21 commits into from
+92 −2
Closed

console: make console consistent with the standard - overridable #12454

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ea237b2
console: make console consistent with the standard - overridable
Wandalen Apr 17, 2017
d98c130
console: make console consistent - writable, not enumerable
Wandalen Apr 17, 2017
4a0669d
console: add WPT footer as requested
Wandalen Apr 17, 2017
fad6725
console: remove extra comments as requested
Wandalen Apr 17, 2017
6e86bca
console : add WPT header as requested
Wandalen Apr 17, 2017
79dc629
console: take care of console set undefined case
Wandalen Apr 17, 2017
e10a6dd
console : remove diagnostic information output
Wandalen Apr 17, 2017
28c32a2
console : fix typo
Wandalen Apr 17, 2017
02768c0
console : few more test cases
Wandalen Apr 17, 2017
5f9d30f
console : stadard remove redundandt test case
Wandalen Apr 17, 2017
bb26718
console : reference specific commit instead of master in test suite
Wandalen Apr 17, 2017
352d504
console : fix jsling issue
Wandalen Apr 17, 2017
197ec07
console : reverse requires in test as requested
Wandalen Apr 17, 2017
c653812
console : => shorthand
Wandalen Apr 22, 2017
5a411bc
console : requested comment
Wandalen May 1, 2017
c9c572a
console : requested comment
Wandalen May 1, 2017
b553b49
console : requested comment
Wandalen May 1, 2017
b7d9771
console : requested comment
Wandalen May 1, 2017
8023728
console : requested comment
Wandalen May 1, 2017
490374f
squash: update test-console-is-a-namespace
Trott Aug 16, 2017
2f43d8d
squash: rename test
Trott Aug 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
console : fix jsling issue
  • Loading branch information
@Wandalen @Trott
Wandalen authored and Trott committed Aug 15, 2017
commit 352d50422e0017ef48055a5f2d7ca9784591b517
1 change: 1 addition & 0 deletions test/parallel/test-console-assing-undefined.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ global.console = undefined;
// lazily loaded in the getter.

Copy link
Copy Markdown
Member

@watilde watilde Apr 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make jslint threw an error:

node/test/parallel/test-console-assing-undefined.js
1:1 error Mandatory module "common" must be loaded required-modules

Copy link
Copy Markdown
Contributor Author

@Wandalen Wandalen Apr 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding require common gives "'common' is assigned a value but never used". What would be appropriate resolution of the problem?

Copy link
Copy Markdown
Contributor Author

@Wandalen Wandalen Apr 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simulating of usage or adding a directive?

Copy link
Copy Markdown
Contributor

@aqrln aqrln Apr 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just don't assign it anywhere. Instead of const common = require('../common'); do require('../common');.

Copy link
Copy Markdown
Contributor Author

@Wandalen Wandalen Apr 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aqrln Smart. Do you participate in OdesaJS this year?

Copy link
Copy Markdown
Contributor Author

@Wandalen Wandalen Apr 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@watilde fixed.

Copy link
Copy Markdown
Contributor

@aqrln aqrln Apr 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wandalen almost there :) The common module should be the first one that a test requires. Please see our guide on writing tests.

Do you participate in OdessaJS this year?

Yep.

Copy link
Copy Markdown
Contributor Author

@Wandalen Wandalen Apr 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aqrln I shall share my experience too if organizers won't be mean :)

const assert = require('assert');
require('../common');

// global.console's getter is called
// Since the `console` cache variable is `undefined` and therefore false-y,
Expand Down