Skip to content

test: use dynamic port in test-dgram-bind-shared-ports #12452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
orafaelfragoso wants to merge 4 commits into from
+0 −0
Closed

test: use dynamic port in test-dgram-bind-shared-ports #12452

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8fdf390
test: use dynamic port in test-dgram-bind-shared-ports
orafaelfragoso Apr 16, 2017
f523cff
test: adding common.mustCall() to socket1 callback
orafaelfragoso Apr 16, 2017
b59f704
test: moved test-dgram-bind-shared-ports to sequential
orafaelfragoso Apr 26, 2017
07d3bf8
test: restoring test-dgram-bind-shared-ports to original
orafaelfragoso Apr 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: use dynamic port in test-dgram-bind-shared-ports 
Use of common.PORT in parallel tests is not completely safe (because
the same port can be previously assigned to another test running in
parallel if that test uses port 0 to get an arbitrary available port).

Remove common.PORT from test-dgram-bind-shared-ports.
  • Loading branch information
@orafaelfragoso
orafaelfragoso committed May 13, 2017
commit 8fdf39004aae8da3225727008e7e1dc0616051d8
4 changes: 2 additions & 2 deletions test/parallel/test-dgram-bind-shared-ports.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,10 @@ if (cluster.isMaster) {

socket1.bind({
address: 'localhost',
port: common.PORT,
port: 0,
exclusive: false
}, () => {
socket2.bind({ port: common.PORT + 1, exclusive: true }, () => {
socket2.bind({ port: socket1.address().port + 1, exclusive: true }, () => {
// the first worker should succeed
process.send('success');
});
Expand Down