Skip to content

test: use dynamic port in test-cluster-dgram-reuse #12426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
orafaelfragoso wants to merge 4 commits into from
Closed

test: use dynamic port in test-cluster-dgram-reuse #12426

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d5af03c
test: use dynamic port in test-cluster-dgram-reuse.js
orafaelfragoso Apr 15, 2017
43bce0a
test: using the dynamic port for both sockets in test-cluster-dgram-r…
orafaelfragoso Apr 15, 2017
7ddb093
test: fixing the wordwrap in test-cluster-dgram-reuse
orafaelfragoso Apr 15, 2017
bab6ccc
test: adding common.mustCall() to callback
orafaelfragoso Apr 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fixing the wordwrap in test-cluster-dgram-reuse 
Fixes the wordwrap error of my last commit based on the guidelines
  • Loading branch information
@orafaelfragoso
orafaelfragoso committed Apr 15, 2017
commit 7ddb0932d1827592cf64868166b2d5affd55d0c4
3 changes: 2 additions & 1 deletion test/parallel/test-cluster-dgram-reuse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ const socket = dgram.createSocket({ type: 'udp4', reuseAddr: true });
// Let the OS assign a random port to the first socket
socket.bind(0, function() {
// Creates the second socket using the same port from the previous one
dgram.createSocket({ type: 'udp4', reuseAddr: true }).bind(socket.address().port, next);
dgram.createSocket({ type: 'udp4', reuseAddr: true })
.bind(socket.address().port, next);
// Call next for the first socket
next.call(this);
});