Skip to content

benchmark: readStart only after completion #12258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
refack merged 1 commit into from
Apr 14, 2017
Merged

benchmark: readStart only after completion #12258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
benchmark,windows: TCP.readStart() meaningful only after completion 
fixes #11972

PR-URL: #12258
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@refack
refack committed Apr 14, 2017
commit fbe946bb6316f1e1083ec47baaf812fc98d60f00
4 changes: 2 additions & 2 deletions benchmark/net/tcp-raw-pipe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,6 @@ function client() {
if (err)
fail(err, 'connect');

clientHandle.readStart();

clientHandle.onread = function(nread, buffer) {
if (nread < 0)
fail(nread, 'read');
Expand All @@ -112,6 +110,8 @@ function client() {

bench.start();

clientHandle.readStart();

setTimeout(function() {
// multiply by 2 since we're sending it first one way
// then then back again.
Expand Down