Skip to content

src: clean up WHATWG URL parser, round 2 #12251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TimothyGu wants to merge 4 commits into from
Closed

src: clean up WHATWG URL parser, round 2 #12251

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c8ea569
src, url: reduce indentation
TimothyGu Apr 6, 2017
c4f78dd
src: refactor URL inlined methods
TimothyGu Apr 5, 2017
cbc1021
src: prefer templates over macros
TimothyGu Apr 6, 2017
e8f1dcc
src: do not export ARG_* flags in url binding
TimothyGu Apr 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
src: do not export ARG_* flags in url binding 
They are unused in the JS layer.
  • Loading branch information
@TimothyGu
TimothyGu committed Apr 15, 2017
commit e8f1dccdda3f5819125292404aa5d6d18163b195
1 change: 0 additions & 1 deletion src/node_url.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2016,7 +2016,6 @@ static void Init(Local<Object> target,
#undef XX

#define XX(name) NODE_DEFINE_CONSTANT(target, name);
ARGS(XX)
PARSESTATES(XX)
#undef XX
}
Expand Down