Skip to content

test: add basic cctest for base64.h #12238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aqrln wants to merge 2 commits into from
Closed

test: add basic cctest for base64.h #12238

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c48697
test: add basic cctest for base64.h
aqrln Apr 5, 2017
851e835
fixup! use const pointers
aqrln Apr 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! use const pointers 
Add accidentally omitted consts for pointers to allocated buffers.
This doesn't actually affect anything in this code, but make const,
not var ;)
  • Loading branch information
@aqrln
aqrln committed Apr 6, 2017
commit 851e8354326ec3f1c5bf84ef8a5cc2168ce02aba
4 changes: 2 additions & 2 deletions test/cctest/test_base64.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ using node::base64_decode;
TEST(Base64Test, Encode) {
auto test = [](const char* string, const char* base64_string) {
const size_t len = strlen(base64_string);
char* buffer = new char[len + 1];
char* const buffer = new char[len + 1];
buffer[len] = 0;
base64_encode(string, strlen(string), buffer, len);
EXPECT_STREQ(base64_string, buffer);
Expand Down Expand Up @@ -47,7 +47,7 @@ TEST(Base64Test, Encode) {
TEST(Base64Test, Decode) {
auto test = [](const char* base64_string, const char* string) {
const size_t len = strlen(string);
char* buffer = new char[len + 1];
char* const buffer = new char[len + 1];
buffer[len] = 0;
base64_decode(buffer, len, base64_string, strlen(base64_string));
EXPECT_STREQ(string, buffer);
Expand Down