Skip to content

Allow all ArrayBufferView types as Buffers #12223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TimothyGu wants to merge 8 commits into from
Closed

Allow all ArrayBufferView types as Buffers #12223

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a8abe9c
src: allow ArrayBufferView as instance of Buffer
TimothyGu Apr 4, 2017
dae94ff
test: add common.getArrayBufferViews(buf)
TimothyGu Apr 4, 2017
c58b945
crypto: support all ArrayBufferView types
TimothyGu Apr 4, 2017
07a399b
zlib: support all ArrayBufferView types
TimothyGu Apr 4, 2017
1459f27
fixup crypto
TimothyGu Apr 5, 2017
039208e
fixup zlib
TimothyGu Apr 5, 2017
072e898
fixup test
TimothyGu Apr 5, 2017
1315240
fixup util
TimothyGu Apr 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add common.getArrayBufferViews(buf)
  • Loading branch information
@TimothyGu
TimothyGu committed Apr 4, 2017
commit dae94ffb7187b3c307f3bcc9b7c4410181492d13
6 changes: 6 additions & 0 deletions test/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,12 @@ The expected error should be [subclassed by the `internal/errors` module](https:

Tests whether `name` and `expected` are part of a raised warning.

## getArrayBufferViews(buf)
* `buf` [<Buffer>](https://nodejs.org/api/buffer.html#buffer_class_buffer)
* return [<ArrayBufferView[]>](https://developer.mozilla.org/en-US/docs/Web/API/ArrayBufferView)

Returns an instance of all possible `ArrayBufferView`s of the provided Buffer.

### hasCrypto
* return [<Boolean>](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Data_structures#Boolean_type)

Expand Down
26 changes: 26 additions & 0 deletions test/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,3 +654,29 @@ exports.skipIfInspectorDisabled = function skipIfInspectorDisabled() {
process.exit(0);
}
};

const arrayBufferViews = [
Int8Array,
Uint8Array,
Uint8ClampedArray,
Int16Array,
Uint16Array,
Int32Array,
Uint32Array,
Float32Array,
Float64Array,
DataView
];

exports.getArrayBufferViews = function getArrayBufferViews(buf) {
const { buffer, byteOffset, byteLength } = buf;

const out = [];
for (const type of arrayBufferViews) {
const { BYTES_PER_ELEMENT = 1 } = type;
if (Number.isInteger(byteLength % BYTES_PER_ELEMENT)) {
Copy link
Copy Markdown
Member

@addaleax addaleax Apr 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean byteLength % BYTES_PER_ELEMENT === 0, or Number.isInteger(byteLength / BYTES_PER_ELEMENT)?

Copy link
Copy Markdown
Member Author

@TimothyGu TimothyGu Apr 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhh… that's embarrassing. Good catch.

out.push(new type(buffer, byteOffset, byteLength / BYTES_PER_ELEMENT));
}
}
return out;
};