Skip to content

Fix building on Windows x86 #12184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joaocgreis wants to merge 2 commits into from
Closed

Fix building on Windows x86 #12184

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6dd0f75
build,win: limit maxcpucount to 2 for MSBuild
joaocgreis Apr 4, 2017
d50bb93
deps,win: increase msvs_shard in gyp for V8
joaocgreis Apr 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
deps,win: increase msvs_shard in gyp for V8 
Increase the number of shards to divide v8_base into. This increases
the number of calls to cl.exe but decreases the number of files
compiled each time.

Fixes: nodejs/v8#4
PR-URL: #12184
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
@joaocgreis
joaocgreis committed Apr 10, 2017
commit d50bb932f6f2faefd01504e5d6b6b871a917d9bb
2 changes: 1 addition & 1 deletion deps/v8/src/v8.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1741,7 +1741,7 @@
# When building Official, the .lib is too large and exceeds the 2G
# limit. This breaks it into multiple pieces to avoid the limit.
# See http://crbug.com/485155.
'msvs_shard': 4,
'msvs_shard': 10,
}],
['component=="shared_library"', {
'defines': [
Expand Down