Skip to content

benchmark, test: test the HTTP benchmark with a dummy benchmarker #12121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 4 commits into from
Closed

benchmark, test: test the HTTP benchmark with a dummy benchmarker #12121

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce42c03
benchmark: add dummy HTTP benchmarker
joyeecheung Mar 29, 2017
4303a5e
benchmark: control HTTP benchmarks run time
joyeecheung Mar 29, 2017
14b27c6
test: add http benchmark test
joyeecheung Mar 29, 2017
21c48b1
s/trouble/double
joyeecheung Apr 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
s/trouble/double
  • Loading branch information
@joyeecheung
joyeecheung committed Apr 8, 2017
commit 21c48b1e51ad294e76cabf7c5ed97cbd1770eb60
8 changes: 4 additions & 4 deletions benchmark/_http-benchmarkers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,10 @@ class WrkBenchmarker {
* Simple, single-threaded benchmarker for testing if the benchmark
* works
*/
class TestTroubleBenchmarker {
class TestDoubleBenchmarker {
constructor() {
this.name = 'test-trouble';
this.executable = path.resolve(__dirname, '_test-trouble-benchmarker.js');
this.name = 'test-double';
this.executable = path.resolve(__dirname, '_test-double-benchmarker.js');
this.present = fs.existsSync(this.executable);
}

Expand Down Expand Up @@ -112,7 +112,7 @@ class TestTroubleBenchmarker {
const http_benchmarkers = [
new WrkBenchmarker(),
new AutocannonBenchmarker(),
new TestTroubleBenchmarker()
new TestDoubleBenchmarker()
];

const benchmarkers = {};
Expand Down
0 benchmark/_test-trouble-benchmarker.js → benchmark/_test-double-benchmarker.js
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion test/sequential/test-benchmark-http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const child = fork(runjs, ['--set', 'dur=0.1',
'--set', 'len=1',
'--set', 'c=1',
'--set', 'chunks=0',
'--set', 'benchmarker=test-trouble',
'--set', 'benchmarker=test-double',
'http'],
{env: {NODEJS_BENCHMARK_ZERO_ALLOWED: 1}});
child.on('exit', (code, signal) => {
Expand Down