Skip to content

doc: fix http properties documented as methods #12039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ahmadnassri wants to merge 2 commits into from
Closed

doc: fix http properties documented as methods #12039

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97d4b5f
doc: fix http properties documented as methods
ahmadnassri Mar 25, 2017
e37a11e
doc: fix https.timeout docs
ahmadnassri Mar 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: fix http properties documented as methods 
- at 9772fb9 [`maxHeadersCount`][maxheaderscount] and [`timeout`][timeout] were erroneously changed to methods
- `maxHeadersCount` was also listed to default to `1000` where it actually is [`2000`][default]

[maxheaderscount]: https://github.com/nodejs/node/blob/e0a9ad1af244f8756a228a6d087b3a55ee4c0d14/lib/_http_server.js#L276
[timeout]: https://github.com/nodejs/node/blob/e0a9ad1af244f8756a228a6d087b3a55ee4c0d14/lib/_http_server.js#L273
[default]: https://github.com/nodejs/node/blob/e0a9ad1af244f8756a228a6d087b3a55ee4c0d14/lib/_http_server.js#L312
  • Loading branch information
@ahmadnassri
ahmadnassri authored Mar 25, 2017
commit 97d4b5f87fb6ef9804096b2986b628cabdc8cbb7
10 changes: 5 additions & 5 deletions doc/api/http.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,14 +794,14 @@ added: v5.7.0
A Boolean indicating whether or not the server is listening for
connections.

### server.maxHeadersCount([limit])
### server.maxHeadersCount
<!-- YAML
added: v0.7.0
-->

* `limit` {number} Defaults to 1000.
* {number} Defaults to 2000.

Limits maximum incoming headers count, equal to 1000 by default. If set to 0 -
Limits maximum incoming headers count, equal to 2000 by default. If set to 0 -
no limit will be applied.

### server.setTimeout([msecs][, callback])
Expand All @@ -825,12 +825,12 @@ to the Server's `'timeout'` event, timeouts must be handled explicitly.

Returns `server`.

### server.timeout([msecs])
### server.timeout
<!-- YAML
added: v0.9.12
-->

* `msecs` {number} Defaults to 120000 (2 minutes).
* {number} Defaults to 120000 (2 minutes).

The number of milliseconds of inactivity before a socket is presumed
to have timed out.
Expand Down