Skip to content

doc: modernize and fix code examples in fs.md #12035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vsemozhetbyt wants to merge 7 commits into from
Closed

doc: modernize and fix code examples in fs.md #12035

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
00e3985
doc: unify quotes in fs.md
vsemozhetbyt Mar 25, 2017
e8f88ec
doc: avoid quote escaping in fs.md
vsemozhetbyt Mar 25, 2017
f02f2d8
doc: simplify logics in fs.md
vsemozhetbyt Mar 25, 2017
599b771
doc: concatenation -> template literal in fs.md
vsemozhetbyt Mar 25, 2017
0994787
doc: add missing callback in fs.md
vsemozhetbyt Mar 25, 2017
43ef4b2
doc: fix typo in fs.md
vsemozhetbyt Mar 25, 2017
6873d71
doc: update output example in fs.md
vsemozhetbyt Mar 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: concatenation -> template literal in fs.md
  • Loading branch information
@vsemozhetbyt
vsemozhetbyt committed Mar 26, 2017
commit 599b771ecb2860a4686d05e40db36a88fada749b
4 changes: 2 additions & 2 deletions doc/api/fs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1282,8 +1282,8 @@ fs.mkdtemp(tmpDir, (err, folder) => {
});

// This method is *CORRECT*:
const path = require('path');
fs.mkdtemp(tmpDir + path.sep, (err, folder) => {
const { sep } = require('path');
fs.mkdtemp(`${tmpDir}${sep}`, (err, folder) => {
if (err) throw err;
console.log(folder);
// Will print something similar to `/tmp/abc123`.
Expand Down