Skip to content

buffer: stricter Buffer.isBuffer #11961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TimothyGu wants to merge 3 commits into from
Closed

buffer: stricter Buffer.isBuffer #11961

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4fceb19
benchmark: add Buffer.isBuffer
TimothyGu Mar 21, 2017
2eab4f8
lib: use Buffer.isBuffer() consistently
TimothyGu Mar 21, 2017
ee2d44a
buffer: stricter Buffer.isBuffer
TimothyGu Mar 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
benchmark: add Buffer.isBuffer
  • Loading branch information
@TimothyGu
TimothyGu committed Sep 21, 2017
commit 4fceb19c0b895d0f00149e71d1485daf9ad198c9
39 changes: 39 additions & 0 deletions benchmark/buffers/buffer-isbuffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
'use strict';
const common = require('../common');
const { Buffer } = require('buffer');

function FakeBuffer() {}
FakeBuffer.prototype = Object.create(Buffer.prototype);

// Refs: https://github.com/nodejs/node/issues/9531#issuecomment-265611061
class ExtensibleBuffer extends Buffer {
constructor() {
super(new ArrayBuffer(0), 0, 0);
Object.setPrototypeOf(this, new.target.prototype);
}
}

const inputs = {
primitive: false,
object: {},
fake: new FakeBuffer(),
subclassed: new ExtensibleBuffer(),
fastbuffer: Buffer.alloc(1),
slowbuffer: Buffer.allocUnsafeSlow(0),
uint8array: new Uint8Array(1)
};

const bench = common.createBenchmark(main, {
type: Object.keys(inputs),
n: [1e7]
});

function main(conf) {
const n = conf.n | 0;
const input = inputs[conf.type];

bench.start();
for (var i = 0; i < n; i++)
Buffer.isBuffer(input);
bench.end(n);
}