Skip to content

test: fix flaky test-tls-socket-close #11921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 7 commits into from
Closed

test: fix flaky test-tls-socket-close #11921

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5db57ca
test: fix flaky test-tls-socket-close
Trott Mar 19, 2017
975a9bd
squash: fix test
Trott Mar 19, 2017
139685d
squash: fix lint
Trott Mar 19, 2017
97508b4
squash: more events, no timers
Trott Mar 19, 2017
83cc066
squash: hopefully this will do it
Trott Mar 19, 2017
553b9f8
squash: cleanup
Trott Mar 19, 2017
8056fcc
squash: comment update
Trott Mar 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 28 additions & 17 deletions test/parallel/test-tls-socket-close.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,35 +9,46 @@ const net = require('net');
const key = fs.readFileSync(common.fixturesDir + '/keys/agent2-key.pem');
const cert = fs.readFileSync(common.fixturesDir + '/keys/agent2-cert.pem');

const T = 100;

let tlsSocket;
// tls server
const tlsServer = tls.createServer({ cert, key }, (socket) => {
setTimeout(() => {
socket.on('error', (error) => {
assert.strictEqual(error.code, 'EINVAL');
tlsServer.close();
netServer.close();
});
socket.write('bar');
}, T * 2);
tlsSocket = socket;
socket.on('error', common.mustCall((error) => {
assert.strictEqual(error.code, 'EINVAL');
tlsServer.close();
netServer.close();
}));
});

let netSocket;
// plain tcp server
const netServer = net.createServer((socket) => {
// if client wants to use tls
// if client wants to use tls
tlsServer.emit('connection', socket);

socket.setTimeout(T, () => {
// this breaks if TLSSocket is already managing the socket:
socket.destroy();
});
netSocket = socket;
}).listen(0, common.mustCall(function() {

// connect client
tls.connect({
host: 'localhost',
port: this.address().port,
rejectUnauthorized: false
}).write('foo');
}).write('foo', 'utf8', common.mustCall(() => {
assert(netSocket);
netSocket.setTimeout(1, common.mustCall(() => {
assert(tlsSocket);
// this breaks if TLSSocket is already managing the socket:
netSocket.destroy();
const interval = setInterval(() => {
// Checking this way allows us to do the right at a time that causes a
Copy link
Copy Markdown
Contributor

@jBarz jBarz Mar 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/right/write/

// segmentation fault (not always, but often) in Node.js 7.7.3 and
// earlier. If we instead, for example, wait on the `close` event, then
// it will not segmentation fault, which is what this test is all about.
if (tlsSocket._handle._parent.bytesRead === 0) {
tlsSocket.write('bar');
clearInterval(interval);
}
}, 1);
}));
}));
}));