Skip to content

Fix 11826 #11920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
clarenced wants to merge 9 commits into from
Closed

Fix 11826 #11920

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
86ff5b0
test: break up the tests in separate file
clarenced Mar 16, 2017
ef6819c
test: lint error correction
clarenced Mar 17, 2017
d1d1a7d
test:lint error correction
clarenced Mar 18, 2017
aeaf585
test: documentation for function childShouldNotThrowAndAbort added
clarenced Mar 19, 2017
8b663fa
test: old file test-domain-abort-on-uncaught.js deleted
clarenced Mar 19, 2017
6156f98
test: documentation fix and msg error update in childShouldNotThrowAn…
clarenced Mar 20, 2017
c78ca3b
test: jslint correction
clarenced Mar 28, 2017
38ac775
test: remove unnecessary indentation
clarenced Apr 2, 2017
4bb01a7
test: blank line between childShouldNotThrowAndAbort and following pa…
clarenced Apr 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: documentation fix and msg error update in childShouldNotThrowAn… 
…dAbort()
  • Loading branch information
@clarenced
clarenced committed Apr 17, 2017
commit 6156f98a7d5aca712b56af1c58c1b18dd5556ebb
4 changes: 2 additions & 2 deletions test/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,8 +416,8 @@ The realpath of the 'tmp' directory.

Name of the temp directory used by tests.

### childShouldNotThrowAndAbort
This test makes sure that when using --abort-on-uncaught-exception and when throwing an error
### childShouldNotThrowAndAbort()
This test makes sure that when using `--abort-on-uncaught-exception` and when throwing an error
from within a domain that has an error handler setup, the process _does not_ abort.

### WPT
Expand Down
6 changes: 3 additions & 3 deletions test/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ exports.childShouldThrowAndAbort = function() {
};


// This test makes sure that when using --abort-on-uncaught-exception and
// This function makes sure that when using --abort-on-uncaught-exception and
// when throwing an error from within a domain that has an error handler
// setup, the process _does not_ abort.

Expand All @@ -269,8 +269,8 @@ exports.childShouldNotThrowAndAbort = () => {

const child = child_process.exec(testCmd);
child.on('exit', (code, signal) => {
const errorMsg = `Test should have exited with exit code 0
but insteand exited with code ${code} and signal ${signal}`;
const errorMsg = 'Test should have exited with exit code 0 but instead ' +
`exited with ${code} and signal ${signal}`;
assert.strictEqual(code, 0, errorMsg);
});
};
Expand Down