Skip to content

url: update the processing in the scheme state. #11887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
watilde wants to merge 2 commits into from
+57 −1
Closed

url: update the processing in the scheme state. #11887

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d4d73f
url: restrict setting protocol to "file"
watilde Mar 17, 2017
18eebe9
test: synchronize WPT url setters tests data
watilde Mar 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
url: restrict setting protocol to "file" 
Since file URLs can not have `username/password/port`,
the specification was updated to restrict setting protocol to "file".

Refs: whatwg/url#269
Fixes: #11785
  • Loading branch information
@watilde
watilde committed Mar 18, 2017
commit 9d4d73ffa9ac1b6d4fc288d09ddb9046630c1e40
7 changes: 7 additions & 0 deletions lib/internal/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,13 @@ function onParseProtocolComplete(flags, protocol, username, password,
if ((s && !newIsSpecial) || (!s && newIsSpecial)) {
return;
}
if (protocol === 'file:' &&
(ctx.username || ctx.password || ctx.port !== undefined)) {
return;
}
if (ctx.scheme === 'file:' && !ctx.host) {
return;
}
if (newIsSpecial) {
ctx.flags |= binding.URL_FLAGS_SPECIAL;
} else {
Expand Down