Skip to content

lib: Use regex to compare error message #11854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kunalspathak wants to merge 3 commits into from
Closed

lib: Use regex to compare error message #11854

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
562be6d
lib: Use regex to compare error message
kunalspathak Mar 15, 2017
83109a9
lib: Addressed review comments
kunalspathak Mar 17, 2017
4d1d901
lib: Addressed review comments
kunalspathak Mar 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
lib: Addressed review comments
  • Loading branch information
@kunalspathak
kunalspathak committed Mar 17, 2017
commit 4d1d9016922f3d41fa265c99b06e9a49e4d30b3e
2 changes: 1 addition & 1 deletion lib/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ function tryStringify(arg) {
CIRCULAR_ERROR_MESSAGE = err.message;
}
}
if (err.name === 'TypeError' && err.message.match(CIRCULAR_ERROR_MESSAGE))
if (err.name === 'TypeError' && err.message === CIRCULAR_ERROR_MESSAGE)
return '[Circular]';
throw err;
}
Expand Down